test(federation): remove qase monkey patch by sampaiodiego · Pull Request #37818 · RocketChat/Rocket.Chat

sampaiodiego · 2025-12-15T17:43:31Z

Proposed changes (including videos or screenshots)

monkey patches are not required anymore after updating library version.

this is the after and before versions:

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Chores
- Updated test framework configuration in the federation-matrix package, removing automated test-reporting setup.
- Adjusted test reporting dependencies across the repo to change how test results are integrated.
- Updated repository ignore rules to exclude logs/ for cleaner repo management.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

dionisio-bot · 2025-12-15T17:43:34Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-12-15T17:43:35Z

⚠️ No Changeset found

Latest commit: 0962368

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-15T17:43:37Z

Walkthrough

Removes Qase Jest integration from the federation-matrix package (deleted setup file and removed setupFilesAfterEnv), moves/updates Jest Qase reporter dependency, and adds logs/ to ee/packages/federation-matrix/.gitignore.

Changes

Cohort / File(s)	Summary
Qase setup removal `ee/packages/federation-matrix/tests/setup-qase.ts`, `ee/packages/federation-matrix/jest.config.federation.ts`	Deleted the Jest Qase setup file and removed `setupFilesAfterEnv` entry from the package's Jest config, disabling the automatic Qase test wrappers.
Dependency changes `ee/packages/federation-matrix/package.json`, `package.json`	Added `jest-qase-reporter` ^2.1.4 to `ee/packages/federation-matrix/package.json` and removed/adjusted the root `jest-qase-reporter` devDependency (previous ^2.1.3).
Ignore rules `ee/packages/federation-matrix/.gitignore`	Added `logs/` to gitignore.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Areas needing attention:
- Ensure no remaining test harness relies on the deleted tests/setup-qase.ts.
- Verify test reporter behavior after dependency relocation.
- Confirm CI/test configs do not reference the removed setup entry.

Possibly related PRs

regression(federation): mongo url, dms etc #37653 — Directly related: removes the same Qase Jest integration pieces from federation-matrix.
chore: qase integration #37538 — Previously added Qase integration that this PR reverts.
test(federation): improve and slim down config and scripts #37769 — Modifies the same federation-matrix test integration (opposite changes).

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

ggazzo
rodrigok

Poem

🐰 I hopped through tests and cleared the way,
Wrapped no more describes today,
Logs tucked out of sight, dependency trimmed light,
Federation-matrix breathes easy by night. 🌙

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing the Qase monkey patch setup file from the federation test configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch test-federation-remove-qase-monkeypatch

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f1fd0bf and 0962368.

📒 Files selected for processing (1)

ee/packages/federation-matrix/jest.config.federation.ts (0 hunks)

💤 Files with no reviewable changes (1)

ee/packages/federation-matrix/jest.config.federation.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: 📦 Build Packages
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-15T18:03:54Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	358MiB	347MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	+2.6KiB
queue-worker-service	132MiB	132MiB	+263B
ddp-streamer-service	126MiB	126MiB	+461B
account-service	113MiB	113MiB	+658B
stream-hub-service	110MiB	110MiB	+1.3KiB
presence-service	110MiB	110MiB	+228B
authorization-service	110MiB	110MiB	+540B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 21:15", "12/15 21:28 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 21 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37818
Baseline: develop
Timestamp: 2025-12-15 21:28:15 UTC
Historical data points: 21

Updated: Mon, 15 Dec 2025 21:28:15 GMT

codecov · 2025-12-15T19:36:49Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.77%. Comparing base (cea565b) to head (0962368).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37818      +/-   ##
===========================================
+ Coverage    67.69%   67.77%   +0.07%     
===========================================
  Files         3457     3457              
  Lines       113831   113836       +5     
  Branches     20908    20909       +1     
===========================================
+ Hits         77061    77148      +87     
+ Misses       34639    34548      -91     
- Partials      2131     2140       +9

Flag	Coverage Δ
e2e	`57.36% <ø> (+0.01%)`	⬆️
e2e-api	`43.23% <ø> (+0.90%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ee/packages/federation-matrix/jest.config.federation.ts

Co-authored-by: Kevin Aleman <kaleman960@gmail.com>

sampaiodiego added 2 commits December 15, 2025 14:41

update qase library and dependencies

02fd5c9

remove setup-qase

f1fd0bf

sampaiodiego marked this pull request as ready for review December 15, 2025 19:13

sampaiodiego added this to the 7.14.0 milestone Dec 15, 2025

KevLehman reviewed Dec 15, 2025

View reviewed changes

ee/packages/federation-matrix/jest.config.federation.ts Outdated Show resolved Hide resolved

Apply suggestion from @KevLehman

0962368

Co-authored-by: Kevin Aleman <kaleman960@gmail.com>

KevLehman approved these changes Dec 15, 2025

View reviewed changes

sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Dec 15, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 15, 2025

sampaiodiego merged commit acf14d6 into develop Dec 15, 2025
49 checks passed

sampaiodiego deleted the test-federation-remove-qase-monkeypatch branch December 15, 2025 21:39

gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026

test(federation): remove qase monkey patch (RocketChat#37818)

ed5bcaf

dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(federation): remove qase monkey patch#37818

test(federation): remove qase monkey patch#37818
sampaiodiego merged 3 commits intodevelopfrom
test-federation-remove-qase-monkeypatch

sampaiodiego commented Dec 15, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sampaiodiego commented Dec 15, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

codecov bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sampaiodiego commented Dec 15, 2025 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Dec 15, 2025 •

edited

Loading

changeset-bot bot commented Dec 15, 2025 •

edited

Loading

coderabbitai bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading

codecov bot commented Dec 15, 2025 •

edited

Loading